Overall this looks good. I am wondering what all the malloc and free costs us
as we might do a few version comparisons during a transaction. Probably not
enough to actually worry. Converting the EVR of the rpmds object just for
comparison seems kinda weird. I am fine with this as a first step but we should
consider moving the rpmds to use versions from the start. Which asks the
question how this relates to rpmsid...
That's not something we want to get into right now but we might want to think
about in the 4.17 time frame. For now it is great we have something like this
at all.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1221#issuecomment-634563090
_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint