The second point is wrong. If `ENABLE_OPENMP` is not defined and `omp.h` is not 
included, build will still fail on:

```
pack.c: In function 'packageBinaries':
pack.c:769:26: error: expected '#pragma omp' clause before 'priority'
  #pragma omp task untied priority(i)
                          ^
```

Following your first feedback on this PR, I sent a patch to disable openmp on 
buildroot side: 
https://patchwork.ozlabs.org/project/buildroot/patch/20201112184600.427081-1-fontaine.fabr...@gmail.com/
I'm still waiting the feedback of the other buildroot members but I think this 
is the only viable option as we can't 'know' the openmp version of every 
toolchain.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1433#issuecomment-736035545
_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Reply via email to