While I like the overall idea of adding type hints to the binding I am not a 
big fan of the  content of python/rpm/_rpm.pyi. This basically duplicates the 
API implementation in the C based API and is very easy to get out of sync. 
Having this generated automatically during build time from the C based binding 
or even the C headers would be much preferred.
If this is not feasible we'd need at least some tests that make sure those 
declarations stay in sync with the binding.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1615#issuecomment-816633046
_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Reply via email to