fakechroot is not required for generating the tests, only for executing them. Thus it makes more sense to test for it at "make check" time. Don't bother with find_program() here, the testsuite isn't using that anyway, it simply assumes a command called "fakechroot" exists in the users path and avoids having to rerun cmake just to make aware of the new tool when installed. Also makes the behavior less confusing when fakechroot is missing.
Fixes: #2288 You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/2291 -- Commit Summary -- * Decouple fakechroot existence testing from check target generation -- File Changes -- M CMakeLists.txt (3) M tests/CMakeLists.txt (6) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/2291.patch https://github.com/rpm-software-management/rpm/pull/2291.diff -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2291 You are receiving this because you are subscribed to this thread. Message ID: <rpm-software-management/rpm/pull/[email protected]>
_______________________________________________ Rpm-maint mailing list [email protected] http://lists.rpm.org/mailman/listinfo/rpm-maint
