@dmnks commented on this pull request.
> + return rc;
+}
+
+static int lookup_num(const char *path, const char *val, int vcol, int rcol,
+ long *ret)
+{
+ char *buf = NULL;
+ int rc = lookup_field(path, val, vcol, rcol, &buf);
+ if (rc == 0) {
+ rc = stol(buf, ret);
+ free(buf);
+ }
+ return rc;
+}
+
+static int lookup_name(const char *path, long val, int vcol, int rcol,
A nitpick but what about `lookup_str()` as a function name instead, for the
sake of consistency? :smile: (The function doesn't do anything specific to
"names")
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2503#pullrequestreview-1495195001
You are receiving this because you are subscribed to this thread.
Message ID: <rpm-software-management/rpm/pull/2503/review/1495195...@github.com>_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
