@dmnks commented on this pull request.
> fi
}
function sandbox()
{
- (unset RPM_CONFIGDIR RPM_POPTEXEC_PATH
- cd ${RPMTEST} && \
- FAKECHROOT_BASE="${RPMTEST}" fakechroot "$@"
- )
+ local cmd=$1
+ shift
+ case $cmd in
+ exec)
+ (unset RPM_CONFIGDIR RPM_POPTEXEC_PATH
+ cd ${RPMTEST} && \
Yup, same goes with the use of curly braces, actually... I know they're needed
in some cases such as when you have adjacent text that could be interpreted as
part of the variable name, but I mix and match both styles quite a lot here
:smile:
I'll fix the quotes though.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2568#discussion_r1255297515
You are receiving this because you are subscribed to this thread.
Message ID: <rpm-software-management/rpm/pull/2568/review/1518007...@github.com>_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
