Don't make any assumptions about how other Linux distros would need to implement the mktree interface. We simply don't know how much logic could be shared between such native backends before some are actually written.
Right now, we only have one such backend, for Fedora, that's a sample size too small to draw any conclusions. Let's worry about refactoring when it actually makes sense and stick with the most basic layout till then. As an example, while unshare(1) works for running DNF as an unprivileged user, it does not seem to work with other package managers and tools that I've tried such as zypper or debootstrap. Those may need another way of doing this or even require sudo(8). Also, --map-auto only exists in the newer unshare(1) versions, older versions would need manual mapping. This also simplifies the "env" command quite a bit, which is nice. No functional changes otherwise. You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/2589 -- Commit Summary -- * Merge mktree.native into mktree.fedora -- File Changes -- M tests/CMakeLists.txt (3) M tests/mktree.fedora (210) D tests/mktree.native (85) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/2589.patch https://github.com/rpm-software-management/rpm/pull/2589.diff -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2589 You are receiving this because you are subscribed to this thread. Message ID: <rpm-software-management/rpm/pull/2...@github.com>
_______________________________________________ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint