Looked at this a little closer. It's doing the unshare() in the main rpm 
process, which may not effect the transaction-in-progress too much, but it'll 
break any future transactions done by the same process by messing the mount 
table. That's a no-go.

This needs to be done post fork() in the scriptlet code, but the caveat is that 
it'll then miss out on Lua scriptlets. I could swear we have a ticket on making 
Lua scriptlets forked too because the current in-process thing is problematic 
in an increasing number of ways, and here's one more.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2617#issuecomment-1697509859
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/2617/c1697509...@github.com>
_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Reply via email to