@ferdnyc commented on this pull request.
> @@ -1349,5 +1349,14 @@ end
end
}
+# example autobuild macros for autotools
+%autobuild_autotools_prep() %autosetup -p1
I'm not sure I understand `%prep` being part of this. It's not going to differ
from one build system to another, and including it in the `%build -a` steps
increases the number of spec files that won't be able to use autobuild because
they need to perform some sort of pre-build shenanigans. (Running `sed` on some
of the extracted files, extracting additional <code>%SOURCE<var>N</var></code>
tarballs, etc...)
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2620#pullrequestreview-1706855222
You are receiving this because you are subscribed to this thread.
Message ID: <rpm-software-management/rpm/pull/2620/review/1706855...@github.com>_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
