> When you build locally, do you see the same failure also _without_ the patch 
> associated with the PR in that CI job?
> 
> This test has hardcoded checksums to test build reproducibility (with 
> `SOURCE_DATE_EPOCH` clamping) so whenever the RPM version changes in 
> `configure.ac` (or `CMakeLists.txt` in 4.19 and later), the checksums change 
> as well since the RPM version is baked into the header when building 
> packages. We typically adjust these checksums manually as part of a release 
> bumping commit.
> 
> There probably are other factors that also cause these checksums to change 
> but I can't think of anything right now.

I reset the rpm-sequoia branch to the last release (v1.5.0), and I see the same 
error.

```
us@alice:/tmp/rpm/rpm-sequoia$ git reset --hard v1.5.0
HEAD is now at f2e5429 Release 1.5.0.
us@alice:/tmp/rpm/rpm-sequoia$ PREFIX=/usr LIBDIR="\${prefix}/lib64"   cargo 
build --release && cargo test --release
...
us@alice:/tmp/rpm/rpm/b/tests$ export 
PKG_CONFIG_PATH=/tmp/rpm/rpm-sequoia/target/release
us@alice:/tmp/rpm/rpm/b/tests$ export 
LD_LIBRARY_PATH=/tmp/rpm/rpm-sequoia/target/release
us@alice:/tmp/rpm/rpm/b/tests$ ../../tests/rpmtests 273
## ---------------------- ##
## rpm 4.18.2 test suite. ##
## ---------------------- ##
273: rpmkeys -Kv <unsigned> 2                        FAILED (rpmsigdig.at:159)

## ------------- ##
## Test results. ##
## ------------- ##

ERROR: 1 test was run,
1 failed unexpectedly.
## ------------------------- ##
## rpmtests.log was created. ##
## ------------------------- ##

Please send `tests/rpmtests.log' and all information you think might help:

   To: <rpm-maint@lists.rpm.org>
   Subject: [rpm 4.18.2] rpmtests: 273 failed

You may investigate any problem if you feel able to do so, in which
case the test suite provides a good starting point.  Its output may
be found below `tests/rpmtests.dir'.

us@alice:/tmp/rpm/rpm/b/tests$ cat rpmtests.dir/273/rpmtests.log
#                             -*- compilation -*-
273. rpmsigdig.at:157: testing rpmkeys -Kv <unsigned> 2 ...
../../tests/rpmsigdig.at:159:


if ! [ -d testing/ ]; then
    cp -aP "${RPMTEST}" .
    chmod -R u+w testing/
    mkdir -p testing/build
    ln -s ../data/SOURCES testing/build/
fi
export RPMTEST="${PWD}/testing"
export TOPDIR="${RPMTEST}/build"
export HOME="${RPMTEST}"

rm -rf "${RPMTEST}"`rpm --eval '%_dbpath'`/*
runroot rpm --initdb


runroot rpmbuild -bb --quiet \
        --define "optflags -O2 -g" \
        --define "_target_platform noarch-linux" \
        --define "_binary_payload w.ufdio" \
        --define "_buildhost localhost" \
        --define "use_source_date_epoch_as_buildtime 1" \
        --define "source_date_epoch_from_changelog 1" \
        --define "clamp_mtime_to_source_date_epoch 1" \
        /data/SPECS/attrtest.spec
for v in SHA256HEADER SHA1HEADER SIGMD5 PAYLOADDIGEST PAYLOADDIGESTALT; do
    runroot rpm -q --qf "${v}: %{${v}}\n" 
/build/RPMS/noarch/attrtest-1.0-1.noarch.rpm
done
runroot rpmkeys -Kv /build/RPMS/noarch/attrtest-1.0-1.noarch.rpm

--- -   2024-01-25 09:03:34.282017503 +0000
+++ /tmp/rpm/rpm/b/tests/rpmtests.dir/at-groups/273/stdout      2024-01-25 
09:03:34.277556707 +0000
@@ -1,8 +1,8 @@
-SHA256HEADER: eb512d3d8c282d0249701032591c53ffb5904c54c95de04783028387b224d8fe
-SHA1HEADER: a42c611d67870c1937623f0da2631eabdf33e948
-SIGMD5: 88d1037686ed3f5f6b67618b02cc47ef
-PAYLOADDIGEST: 116ce41ebb72f1877cda3d7dedaf5b78770e202d6389ade4e415d78548d703a8
-PAYLOADDIGESTALT: 
116ce41ebb72f1877cda3d7dedaf5b78770e202d6389ade4e415d78548d703a8
+SHA256HEADER: 94d13620f7058c14f24605c1461a9ef89b5b50b80c421a0a0eb7f0c62fe0f638
+SHA1HEADER: 8036a9b66aa7781e4000a441e695bb076acfc450
+SIGMD5: 98d3343d19052974392ed389e121f4f8
+PAYLOADDIGEST: 91438332ac8fe92e4d4fcd45edb64b659323b893d9496a339f8587d19d00531a
+PAYLOADDIGESTALT: 
91438332ac8fe92e4d4fcd45edb64b659323b893d9496a339f8587d19d00531a
 /build/RPMS/noarch/attrtest-1.0-1.noarch.rpm:
     Header SHA256 digest: OK
     Header SHA1 digest: OK
273. rpmsigdig.at:157: 273. rpmkeys -Kv <unsigned> 2 (rpmsigdig.at:157): FAILED 
(rpmsigdig.at:159)
```

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2874#issuecomment-1909703296
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/issues/2874/1909703...@github.com>
_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Reply via email to