That's the essence of it, yes.
One thing that did catch my eye:
the %buildsystem_foo_install() and such macros do not take options currently
because they'd be shared across all buildsystems. So eg
`%buildsystem_pyproject_check(e:t)` will not do what you intend, there's no way
to pass options to the buildsystem macro itself. What you pass to
BuildOption(): will get passed as an *argument* (ie after `--`) to this macro,
which you just pass along to the thing actually implementing it - such as
`%pyproject_*` here.
As for #2859, the new -C flag is not automatically enabled anywhere just now,
it probably should be in %buildsystem_default_prep() though, that's a good
point.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/discussions/2997#discussioncomment-8915180
You are receiving this because you are subscribed to this thread.
Message ID:
<rpm-software-management/rpm/repo-discussions/2997/comments/8915...@github.com>
_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint