@pmatilai commented on this pull request.


> +[0],
+[hello-1.0-1
+],
+[])
+RPMTEST_CLEANUP
+
+AT_SETUP([rpmspec -q --srpm])
+AT_KEYWORDS([query])
+RPMTEST_CHECK([
+RPMDB_INIT
+runroot rpmspec --srpm \
+  -q  /data/SPECS/hello.spec
+],
+[0],
+[hello-1.0-1.src
+],

I'd put this in the same SETUP/CLEANUP group as the --rpms tests, just in its 
own RPMTEST_CHECK() block. These have a not-entirely-trivial cost especially 
now in the containerized setup. This doesn't write anything either so 
RPMDB_INIT is unncessary (and lack of which actually guards against things 
unexpectedly starting to write stuff too).

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2995#pullrequestreview-1973243310
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/2995/review/1973243...@github.com>
_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Reply via email to