@pmatilai commented on this pull request.
> }
- if (rpmMkdirs(rpmtxnRootDir(txn), "%{_keyringpath}")) {
+ free(dir);
+ return rc;
+}
+
+/*****************************************************************************/
+
+static rpmRC acquire_write_lock(rpmtxn txn)
I don't see concurrent access with other tools being something we need to
support. Poking at rpm directories with external tools is more like a developer
convenience thing rather than something we'd be suggesting to users. But, if
you want to support locking then the actual lock seems to be missing,
https://www.ietf.org/archive/id/draft-nwjw-openpgp-cert-d-00.html#platform-specifics
says it should use flock().
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3437#discussion_r1836410039
You are receiving this because you are subscribed to this thread.
Message ID: <rpm-software-management/rpm/pull/3437/review/[email protected]>_______________________________________________
Rpm-maint mailing list
[email protected]
http://lists.rpm.org/mailman/listinfo/rpm-maint
