@ffesti commented on this pull request.


>  
-    if (replace) {
-       rasprintf(&tmppath, "%s.new", path);
-       unlink(tmppath);
+    rc = write_key_to_disk(key, dirstr, keyfmt, replace, flags);
+
+    if (!rc && replace) {
+       /* find and delete the old pubkey entry */

Yeah, I thought it wouldn't make a big difference having it in one patch as it 
just adds the new backend. I should have reconsidered when seeing the mess the 
diff made out of that.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3437#discussion_r1836993450
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/3437/review/[email protected]>
_______________________________________________
Rpm-maint mailing list
[email protected]
http://lists.rpm.org/mailman/listinfo/rpm-maint

Reply via email to