rpmuncompress relies on macros for much of what it does, thus they need to be 
overridable on the command line just like with rpmbuild. This is the first 
piece towards having the rpm macro context passed down to rpmuncompress as 
needed.

One subtlety here is the use of rpm log context rpmIsVerbose() for verbosity: 
rpmbuild itself by default runs in verbose mode by default, and on first 
thought it seems this would affect the rpmuncompress operation. It doesn't, 
because rpmuncompress is a separate process with its own rpmlog context.

rpm-common(8) includes more things than rpmuncompress actually supports, but 
that's another flaw shared by rpmspec/rpmsign/rpmbuild etc that do not 
honor --root and friends either.

Fixes: #3646
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/4007

-- Commit Summary --

  * Honor rpm-common(8) options in rpmuncompress

-- File Changes --

    M docs/man/rpmuncompress.1.scd (8)
    M tests/rpmbuild.at (24)
    M tools/rpmuncompress.cc (20)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/4007.patch
https://github.com/rpm-software-management/rpm/pull/4007.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/4007
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/[email protected]>
_______________________________________________
Rpm-maint mailing list
[email protected]
https://lists.rpm.org/mailman/listinfo/rpm-maint

Reply via email to