I originally fancied doing some more elaborate c++ conversions while doing this, but the main source of these mixed comparisons are signed integers being used for indexing several arrays at once, and that's a case where range-for and friends aren't that useful. So, just do the bare minimum to eliminate the signed comparisons without adding casts all over the place. You can view, comment on, or merge this pull request online at:
https://github.com/rpm-software-management/rpm/pull/3989 -- Commit Summary -- * Move -Wno-sign-compare to individual target_compile_options() * Drop a redundant .resize() on vector before .insert() * Use unsigned integer for number of files * Use unsigned int for the for-loop index * Trivial signed/unsigned type fixups for Fread()/Fwrite() return * Fix mixed signedness comparisons in generateBuildIDs() * Use unsigned integers for number of files, part II * Add + use a helper function to make ptr distance strlen() compatible * Drop -Wno-sign-compare from librpmbuild build options -- File Changes -- M CMakeLists.txt (1) M build/files.cc (44) M build/pack.cc (2) M build/parseSpec.cc (2) M build/rpmfc.cc (20) M lib/CMakeLists.txt (2) M rpmio/CMakeLists.txt (1) M sign/CMakeLists.txt (1) M tools/CMakeLists.txt (1) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/3989.patch https://github.com/rpm-software-management/rpm/pull/3989.diff -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3989 You are receiving this because you are subscribed to this thread. Message ID: <rpm-software-management/rpm/pull/[email protected]>
_______________________________________________ Rpm-maint mailing list [email protected] https://lists.rpm.org/mailman/listinfo/rpm-maint
