When looking for a Dockerfile that's compatible with the host OS, also look 
at the OS version (not just name). We override `FROM` to the OS version anyway, 
so actually check if the given version is supported. That's now indicated 
by Dockerfile symlinks.

Additionally, print a warning when no matching Dockerfile is found, which looks 
like this (on a hypothetical Fedora 45):

```
CMake Warning at tests/CMakeLists.txt:106 (message):
  Could NOT find matching Dockerfile for host fedora-45 (found: fedora-43,
  fedora-44).  Reverting to containerized test builds.
```

Fixes: #4213 
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/4214

-- Commit Summary --

  * Match Dockerfile against OS version too
  * Emit CMake warning for no matching Dockerfile

-- File Changes --

    M tests/CMakeLists.txt (20)
    M tests/Dockerfile.fedora (1)
    A tests/Dockerfile.fedora-43 (1)
    A tests/Dockerfile.fedora-44 (1)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/4214.patchhttps://github.com/rpm-software-management/rpm/pull/4214.diff
-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/4214
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/[email protected]>
_______________________________________________
Rpm-maint mailing list
[email protected]
https://lists.rpm.org/mailman/listinfo/rpm-maint

Reply via email to