http://bugzilla.rpmfusion.org/show_bug.cgi?id=54
Thorsten Leemhuis <[EMAIL PROTECTED]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[EMAIL PROTECTED] --- Comment #12 from Thorsten Leemhuis <[EMAIL PROTECTED]> 2008-11-05 12:39:29 --- (In reply to comment #11) > - Those conditionals are perfectly valid and work as needed, no matter of why > they would be needed in case we wouldn't expect. Just a note: I totally agree with what the statement from Dominik. I for one would not approve packages that have more then 5 conditionals. Even 5 are IMHO to much, but it's a trade of that sometimes are acceptable to makes things easier. The spec file that is up for review has way more then 5 conditionals; it IMHO even violates this rule from the review guidelines: MUST: The spec file for the package MUST be legible. [...] Fedora is not the place for entries into the Obfuscated Code Contest (http://www.ioccc.org/). Just my 2 cent -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.