http://bugzilla.rpmfusion.org/show_bug.cgi?id=165
--- Comment #4 from Conrad Meyer <kon...@tylerc.org> 2008-12-15 23:40:15 --- (In reply to comment #3:) > Just some questions for now: > > * You should really clean up the script. If you don't use patches than do > not include them. OK. > * Why do you do > ./configure [..] exampledir=%{_datadir}/%{name}/examples [..] > and then move examples directory somewhere else? > > Just set exampledir as %{_defaultdocdir}/%{name}-%{version}/examples and > declare this dir in the "files" section. Ah, that's a good idea :). I tried the above and got this in %doc, though: error: magic_file(ms, "/var/tmp/cmus-2.2.0-2.fc9-root-konrad/usr/share/doc/cmus-2.2.0/examples") failed: mode 040755 cannot open `/var/tmp/cmus-2.2.0-2.fc9-root-konrad/usr/share/doc/cmus-2.2.0/examples' (No such file or directory) rpmbuild: rpmfc.c:1386: rpmfcClassify: Assertion `ftype != ((void *)0)' failed. Aborted > * Why don't you use CONFIG_FFMPEG=y to have .wma support? Because as of ffmpeg 0.4.9-0.48.20080908.fc9 this feature doesn't compile. > * Why do you use both libmodplug and libmikmod since both are used to have > .mod and .x3m support? I'm not familiar with .mod/.x3m, can you help me here? > * I wonder if libraries should be moved to different packages. Thus the final > user can choose what to install based on his needs. Each one is only a few kilobytes (5-15 kiB on x86_64 systems) so I'm inclined to say just leave them in the main package. > * There is no compile output. Makefile must be patched to see it. OK. > * Missing doc files: AUTHORS OK. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.