http://bugzilla.rpmfusion.org/show_bug.cgi?id=195
[email protected] changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #2 from [email protected] 2009-01-17 05:29:54 --- (In reply to comment #1) > The package seems in shape. There are a suggestion (!), a few issues that need > to be corrected (*) and a question (?) > ! If you use a delimiter other than / on sed, it will make things easier to > read. Wrong. / is mandatory on sed "deletes". > * Please explain all non-trivial things you do in a SPEC file (especially the > sed and rm commands) as comments These are common Fedora perl packaging standards, you should be familiar with. > * Please preserve the timestamps of non-compiled files. Superfluous - It's an urban legend that this would fix anything. > * The file "changes" should go to %doc Correct ... SHOULD. > ? Packages must not own files or directories already owned by other packages. > %{perl_vendorarch}/Crypt/ and %{perl_vendorarch}/auto/Crypt/ are owned by > crypto-utils. But there is an exception rule for perl packages and I believe > this package falls into that category. Am I right? Almost. Your final conclusion is right (these dirs must be owned), but your explanation is not quite right. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
