http://bugzilla.rpmfusion.org/show_bug.cgi?id=782
Hans de Goede <j.w.r.dego...@hhs.nl> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |3
Status|NEW |ASSIGNED
--- Comment #2 from Hans de Goede <j.w.r.dego...@hhs.nl> 2009-09-07 13:35:29
---
Full review done, looks good, only issue I have is that I don't like the
Conflicts. Looking at %install it should be very easy to just install this as
/usr/bin/sonic-visualiser-freeworld
And also rename the icon and update the .desktop to refer the renamed icon
(and rename the .desktop too).
This way we don't need the Conflicts, I know having both installed makes little
sense, but AFAIK Conflicts will confuse yum and esp. PackageKit, so by avoiding
the conflict, we allow users to use gui tools to install this even if they also
have the Fedora version.
Also, please update the icon cache scripts to match the new template:
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Icon_Cache
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
