http://bugzilla.rpmfusion.org/show_bug.cgi?id=1313
Rex Dieter <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #35 from Rex Dieter <[email protected]> 2010-09-10 16:51:30 --- A few quick comments, 1. MUST: please include a separate lightspark.desktop Source, instead of cat'ing inline in the .spec 2. MUST: remove alternatives baggage (discussed on irc), Provides: flash-plugin 3. MUST: remove Requires: gnash , and document it's optional use in %%description insead (discussed on irc). I think it checks for this ability at buildtime too, may want BuildRequires: gnash so that it's found explicitly (else, seems to default to looking for /usr/bin/gnash , which is ok too). your call. 4. SHOULD: consider using GraphicsMagick or ImageMagick (or your favorite tool) to convert svg icons into 1 or 2 common-sized png's as well. otherwise, Naming: ok License: (tentative) ok (I see a few mentions of mpl/gplv2/lgplv2 in some headers, will have to double-check) scriptlets: ok sources: ok md5sum *.gz 20a9eaf9259915d6aa7fc39048aece78 lightspark-0.4.4.1.tar.gz So far so good. If you can address items 1-4, we're looking good. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
