https://bugzilla.rpmfusion.org/show_bug.cgi?id=2109
Richard <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #1 from Richard <[email protected]> 2011-12-27 19:17:01 CET --- This is an informal review since I can't sponsor you. 1. There's no point in defining name, version, and release macros manually. You get them for free when you use the Name, Version, and Release tags. Also, you should use the dist tag "%{?dist}" on the end of the release number of the Release tag. 2. If the Source: tag isn't a full URL then you need to explain with comments how the source was obtained sufficient for another to generate the same archive[1]. 3. Buildroot, rm -rf $RPM_BUILD_ROOT in %install, all of %clean, and %defattr in %files are not needed unless you want to build for EL5[2]. 4. Packager and Vendor tags should not be used[3]. 5. Description header in %description is redundant and doesn't aid readability. Both rpm and yum will add their own "Description" header during info display. 6. Is "--record=INSTALLED_FILES" the required method for installing with this package? Does the standard method[1] not work? 7. Generally the BuildRequires: should be one per line unless there's a logical grouping, listing them all together is a readability problem. [1] http://fedoraproject.org/wiki/Packaging:SourceURL [2] http://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag [3] http://fedoraproject.org/wiki/Packaging:Guidelines -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.
