https://bugzilla.rpmfusion.org/show_bug.cgi?id=2190
Alec Leamas <leamas.a...@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |leamas.a...@gmail.com --- Comment #1 from Alec Leamas <leamas.a...@gmail.com> 2012-02-22 20:39:00 CET --- Hi Avi! I'm not a reviewer, but perhaps I can help you with some random remarks after a quick check: Dont use the %__rm, %__cp macros, use simple 'rm', 'cp' 'c++' instead See http://fedoraproject.org/wiki/Packaging:Guidelines#Macros The License: tag does not reflect the fact that some code is MIT/X11 licensed. See http://fedoraproject.org/wiki/Packaging:Guidelines#Licensing. You can't add COPYING yourself, you must contact upstream about that. And upstream has already a COPYING in place. Are you replacing it? This is not possible either for legal reasons. After all, it's their code. If you have problem with the fsf-address lint warning, just report to upstream, bring the link (e. g., bugtracker ticket) in here and live with the warning. Remove Buildroot:, %clean, %defattr. These are not used in Fedora. The Source0 url is wrong, it just fetches a html page. See http://fedoraproject.org/wiki/Packaging:SourceURL, note the sourceforge chapter. Rpmlint shows empty debug package. Probably related to that you remove the -g option to g++. You should not do that, generate debug info and let rpmbuild strip to the debug package instead. And run rpmlint on the debug package as well. You don't need to require c++, make etc. See: http://fedoraproject.org/wiki/Packaging:Guidelines#Exceptions_2 Style is a matter of personal taste. However, you might consider to: Line up the first section properly: Summary: Command-Line Program to Read and Set iTunes-style Metadata Tags URL: http://atomicparsley.sourceforge.net Name: AtomicParsley Version: 0.9.0 Release: 7%{?dist} License: GPLv2 Write the sed code on one line (note there's only the last one left when you're done) sed -i -e 's/g++/$CXX/g' -e 's/-g//g' -e 's/-O2/$OPTFLAGS/g' build Write the %doc list on one line: %doc COPYING AP\ buglist.txt Using\ AtomicParsley.rtf Still, formatting is personal and not review remarks. -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.