https://bugzilla.rpmfusion.org/show_bug.cgi?id=2449
--- Comment #3 from Jussi Lehtola <[email protected]> 2012-08-20 17:15:30 CEST --- rpmlint output: yle-dl.src: W: spelling-error %description -l en_US boxee -> boxer, boxes, boxen yle-dl.x86_64: W: spelling-error %description -l en_US boxee -> boxer, boxes, boxen yle-dl.x86_64: W: incoherent-version-in-changelog 2.0.1 ['2.0.1-2.fc17', '2.0.1-2'] yle-dl.x86_64: E: no-binary yle-dl.x86_64: W: no-manual-page-for-binary yle-dl yle-dl-debuginfo.x86_64: E: empty-debuginfo-package 3 packages and 0 specfiles checked; 2 errors, 4 warnings. ** Fix the changelog entry. ** The package only contains a Python script. Thus, add BuildRequires: python-devel BuildArch: noarch ** Drop the make command make DESTDIR=%{_usr} prefix=%{_usr} INC=-I/usr/include/json which isn't necessary in the 2.0 series (there's nothing to build). ** %{_bindir}/* Please don't use wildcards where they are not necessary. Just write %{_bindir}/yle-dl instead. ** MUST: The package does not yet exist in Fedora. The Review Request is not a duplicate. OK - Appropriate for rpmfusion since package requires rtmpdump, which is only available in RPMFusion. MUST: The spec file for the package is legible and macros are used consistently. OK - After changes requested above. MUST: The package must be named according to the Package Naming Guidelines. OK MUST: The spec file name must match the base package %{name}. OK MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines. OK MUST: The License field in the package spec file must match the actual license. OK MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. OK $ sha1sum yle-dl-2.0.1.tar.gz ../SOURCES/yle-dl-2.0.1.tar.gz 6b9e75c60a2b678059da9686e934281c768c79c7 yle-dl-2.0.1.tar.gz 6b9e75c60a2b678059da9686e934281c768c79c7 ../SOURCES/yle-dl-2.0.1.tar.gz MUST: The package MUST successfully compile and build into binary rpms. OK MUST: The spec file MUST handle locales properly. N/A MUST: Optflags are used and time stamps preserved. OK MUST: Packages containing shared library files must call ldconfig. N/A MUST: A package must own all directories that it creates or require the package that owns the directory. OK MUST: Files only listed once in %files listings. OK MUST: Debuginfo package is complete. N/A MUST: Permissions on files must be set properly. OK MUST: Large documentation files must go in a -doc subpackage. N/A MUST: All relevant items are included in %doc. Items in %doc do not affect runtime of application. OK MUST: Desktop files are installed properly. N/A MUST: No file conflicts with other packages and no general names. OK SHOULD: %{?dist} tag is used in release. OK SHOULD: If the package does not include license text(s) as separate files from upstream, the packager should query upstream to include it. OK SHOULD: The package builds in mock. OK EPEL: Clean section exists. OK EPEL: Buildroot cleaned before install. OK EPEL: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'. N/A -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
