https://bugzilla.rpmfusion.org/show_bug.cgi?id=2577
Richard <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #2 from Richard <[email protected]> 2012-12-19 16:26:57 CET --- (In reply to comment #1) > There is a similar review request at bug 1539 . Perhaps someone on that bug > could review your package, or vice versa? Yes, we need to see if the original packager still wants to pursue their review or not. In case the answer is no, here's a quick spec review: 1. Should the following be marked as documentation? %{_docdir}/%{name} move to: %doc CHANGELOG %{_docdir}/%{name} 2. You need to add "hicolor-icon-theme" to the BuildRequires: as it owns /usr/share/icons/hicolor This is a non-intuitive requirement but you're not supposed to install files into directories the package doesn't own without BR: the package. -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.
