https://bugzilla.rpmfusion.org/show_bug.cgi?id=2979
--- Comment #35 from Alec Leamas <leamas.a...@gmail.com> 2013-10-23 21:34:33 CEST --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== Issues: - Nicholas suggests using ExclusiveArch: i686, lets stick to that. Generic: [!]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. --> OK for rpmfusion. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 1 files have unknown license. Detailed output of licensecheck in /home/mk/FedoraReview/2979-steam/licensecheck.txt [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/udev, /etc/profile.d, /usr/lib/udev/rules.d [-]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: update-desktop-database is invoked in %post and %postun if package contains desktop file(s) with a MimeType: entry. Note: desktop file(s) with MimeType entry in steam [x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package contains icons. Note: icons in steam [x]: Useful -debuginfo package or justification otherwise. [-]: Package is not known to require an ExcludeArch tag. Well, it does, it's correct and that's how it is. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 30720 bytes in 4 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop- file-validate if there is such a file. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: steam-1.0.0.43-6.fc21.i686.rpm steam-1.0.0.43-6.fc21.src.rpm steam.i686: E: explicit-lib-dependency libXau(x86-32) steam.i686: E: explicit-lib-dependency libXdmcp(x86-32) steam.i686: E: explicit-lib-dependency libappindicator(x86-32) steam.i686: E: explicit-lib-dependency libasyncns(x86-32) steam.i686: E: explicit-lib-dependency libattr(x86-32) steam.i686: E: explicit-lib-dependency libffi(x86-32) steam.i686: E: explicit-lib-dependency libpng12(x86-32) steam.i686: E: explicit-lib-dependency libsndfile(x86-32) steam.i686: E: explicit-lib-dependency libtxc_dxtn(x86-32) steam.i686: E: explicit-lib-dependency libusbx(x86-32) steam.i686: W: name-repeated-in-summary C Steam steam.i686: W: spelling-error %description -l en_US savegame -> save game, save-game, pregame steam.i686: W: spelling-error %description -l en_US screenshot -> screen shot, screen-shot, screens hot steam.i686: W: invalid-license Steam License Agreement steam.i686: E: no-binary steam.i686: W: only-non-binary-in-usr-lib steam.i686: W: desktopfile-without-binary /usr/share/applications/steam.desktop /usr/bin/steam steam.src: W: name-repeated-in-summary C Steam steam.src: W: spelling-error %description -l en_US savegame -> save game, save-game, pregame steam.src: W: spelling-error %description -l en_US screenshot -> screen shot, screen-shot, screens hot steam.src: W: invalid-license Steam License Agreement 2 packages and 0 specfiles checked; 11 errors, 10 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint steam steam.i686: E: explicit-lib-dependency libXau(x86-32) steam.i686: E: explicit-lib-dependency libXdmcp(x86-32) steam.i686: E: explicit-lib-dependency libappindicator(x86-32) steam.i686: E: explicit-lib-dependency libasyncns(x86-32) steam.i686: E: explicit-lib-dependency libattr(x86-32) steam.i686: E: explicit-lib-dependency libffi(x86-32) steam.i686: E: explicit-lib-dependency libpng12(x86-32) steam.i686: E: explicit-lib-dependency libsndfile(x86-32) steam.i686: E: explicit-lib-dependency libtxc_dxtn(x86-32) steam.i686: E: explicit-lib-dependency libusbx(x86-32) steam.i686: W: name-repeated-in-summary C Steam steam.i686: W: spelling-error %description -l en_US savegame -> save game, save-game, pregame steam.i686: W: spelling-error %description -l en_US screenshot -> screen shot, screen-shot, screens hot steam.i686: W: invalid-license Steam License Agreement steam.i686: E: no-binary steam.i686: W: only-non-binary-in-usr-lib 1 packages and 0 specfiles checked; 11 errors, 5 warnings. # echo 'rpmlint-done:' Requires -------- steam (rpmlib, GLIBC filtered): /bin/sh /usr/bin/env NetworkManager-glib(x86-32) SDL2(x86-32) alsa-lib(x86-32) alsa-plugins-pulseaudio(x86-32) avahi-libs(x86-32) config(steam) expat(x86-32) gtk2(x86-32) harfbuzz(x86-32) json-c(x86-32) keyutils-libs(x86-32) libXau(x86-32) libXdmcp(x86-32) libappindicator(x86-32) libasyncns(x86-32) libattr(x86-32) libffi(x86-32) libpng12(x86-32) libsndfile(x86-32) libtxc_dxtn(x86-32) libusbx(x86-32) mesa-libEGL(x86-32) mesa-libGL(x86-32) mesa-libgbm(x86-32) nss(x86-32) openal-soft(x86-32) openssl-libs(x86-32) pcre(x86-32) pixman(x86-32) pulseaudio-libs(x86-32) tar tcp_wrappers-libs(x86-32) zenity Provides -------- steam: application() application(steam.desktop) config(steam) mimehandler(x-scheme-handler/steam) steam steam(x86-32) Source checksums ---------------- http://repo.steampowered.com/steam/pool/steam/s/steam/steam_1.0.0.43.tar.gz : CHECKSUM(SHA256) this package : 7c22d08944183c6b0fe5c62e6ba71beece8fe11146e3a15e9ee8bcddebb7bc8f CHECKSUM(SHA256) upstream package : 7c22d08944183c6b0fe5c62e6ba71beece8fe11146e3a15e9ee8bcddebb7bc8f Generated by fedora-review 0.5.0 (928f2b2) last change: 2013-10-14 Command line :./try-fedora-review -m fedora-rawhide-i386-rpmfusion_nonfree --other-bz=https://bugzilla.rpmfusion.org/ -b 2979 Buildroot used: fedora-rawhide-i386 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.