Sorry, first reply was based on first answer ie. e., first patch. The new numbers (+124, -184) are definitely something else. That said, I don't really think it changes my overall conclusion that a try to push this upstream should be done.
On 1/25/14, Alec Leamas <[email protected]> wrote: > Well, in my eyes this actually doesn't look that bad. All in all 37 > lines gone, 130 added, including some whitespace changes. > > My first reaction when seeing this that this does not warrant an > exception, at least not without a try to push things upstream. Note > the following in [1]: > > --- > Why haven't the changes been pushed to the upstream library? If no > attempt has been made to push the changes upstream, we shouldn't be > supporting people forking out of laziness. > --- > > > --alec > > [1] https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries > > > On 1/25/14, Miro Hrončok <[email protected]> wrote: >>> https://github.com/xylosper/mpv/compare/mpv-player:master...master.diff >> >> Sorry, I meant >> https://github.com/xylosper/mpv/compare/mpv-player:master...master.patch >> >> -- >> Miro Hrončok >> -- >> Phone: +420777974800 >> IRC: mhroncok >> >
