https://bugzilla.rpmfusion.org/show_bug.cgi?id=4532
Nicolas Chauvet <kwiz...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
namespace| |free
Assignee|pikachu.2...@gmail.com |kwiz...@gmail.com
Flags| |fedora-review?
--- Comment #21 from Nicolas Chauvet <kwiz...@gmail.com> ---
(In reply to Mohamed El Morabity from comment #19)
> Sorry for the late answer. A lot of work at my job unfortunately.
>
> Your package seems quite good now. Some notes:
>
> - Fix BR condition on kodi-devel, which should match the one on kodi in
> Requires:
> BuildRequires: kodi-devel >= %{kodi_version}
It would means the project itslef requires at least this kodi version whereas
it might be possible to build for several kodi version (say 16 and 17 or
later).
What would be needed instead if to enforce a build to be at least >= than the
version of kodi it was built against.
So it means it would be easier if koji_version RPM macro would be defined in
the kodi-devel package so dependent package could use it.
Reviewing the package.
--
You are receiving this mail because:
You are on the CC list for the bug._______________________________________________
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
