https://bugzilla.rpmfusion.org/show_bug.cgi?id=4441
--- Comment #21 from Andrew Bauer <zonexpertconsult...@outlook.com> ---
We are making progress. Just a few more hurdles.
TO-DO:
------
- Update to discord 0.0.3
- As mentioned in an earlier post, use desktop-file-install or
desktop-file-validate to install the desktop file.
- Removal of AutoReqProv: No has caused the rpm to be uninstallable due to
uninstallable libffmpeg.so. Fix with:
> %global __requires_exclude libffmpeg.so
- I went through several non-free source rpms to find some kind of standard
license naming for rpms with pre-built binaries but saw none. I would, however,
ask that you link Chris' comment to the specfile:
># License information: https://bugzilla.rpmfusion.org/show_bug.cgi?id=4441#c14
>License: Proprietary
TOTAL NIT PICK:
---------------
- use %{buildroot} or $RPM_BUILD_ROOT but not both
- Replace the tab after ExcluseiveArch with two spaces
ADDITIONAL NOTES - No Followup Required
-----------------
Most of the warnings and errors were addressed earlier by Sean.
The Fedora Review tool was not able to download the discord tarball, but
spectool was able to just fine. I'm writing this off as a false positive.
rpmlint explicit-lib-dependency - The explicit dependencies in fact required.
Rpm does not properly detect these.
rpmlint binaryinfo-readelf-failed & ldd-failed - Yes, it could be argued bad
practice to hide zip files under /usr/lib64, but the Discord binary ships
pre-compiled to look there. There is nothing I am aware of that we can do to
fix this other then mention it to upstream.
Sean, if you could knock out the requested changes, I'll approve this package
asap and we can get this into rpmfusion. I'm willing to co-maintain this with
you if you want.
--
You are receiving this mail because:
You are on the CC list for the bug._______________________________________________
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
