https://bugzilla.rpmfusion.org/show_bug.cgi?id=4647
Dominik 'Rathann' Mierzejewski <[email protected]> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #26 from Dominik 'Rathann' Mierzejewski <[email protected]> ---
(In reply to Richard from comment #25)
> SPEC: https://www.dropbox.com/s/a3fy23xaw163ap5/unifi.spec?dl=0
> SRPM: https://www.dropbox.com/s/q6vi2pfpv5wgkbi/unifi-5.7.20-1.fc27.src.rpm
>
> * Thu Mar 08 2018 Richard Shaw <[email protected]> - 5.7.20-1
> - Update to 5.7.20.
> - Add new webrtc target aarch64.
>
> I also split the noarch stuff into a data subpackage...
Nice. One final nitpick:
[...]
%ifarch x86_64
mkdir -p %{buildroot}%{_datadir}/unifi/lib/native/Linux/x86_64
mv Linux/x86_64/libubnt_webrtc_jni.so %{buildroot}%{_libdir}/
ln -sr %{buildroot}%{_libdir}/libubnt_webrtc_jni.so \
%{buildroot}%{_datadir}/unifi/lib/native/Linux/x86_64/
%endif
%ifarch armv7hl
mkdir -p %{buildroot}%{_datadir}/unifi/lib/native/Linux/armv7
mv Linux/armv7/libubnt_webrtc_jni.so %{buildroot}%{_libdir}/
ln -sr %{buildroot}%{_libdir}/libubnt_webrtc_jni.so \
%{buildroot}%{_datadir}/unifi/lib/native/Linux/armv7/
%endif
%ifarch aarch64
mkdir -p %{buildroot}%{_datadir}/unifi/lib/native/Linux/aarch64
mv Linux/aarch64/libubnt_webrtc_jni.so %{buildroot}%{_libdir}/
ln -sr %{buildroot}%{_libdir}/libubnt_webrtc_jni.so \
%{buildroot}%{_datadir}/unifi/lib/native/Linux/aarch64/
%endif
[...]
This looks overly repetitive and could be handled better, for example:
%ifarch aarch64 armv7hl x86_64
%ifarch armv7hl
%global unifi_arch armv7
%else
%global unifi_arch %{_target_cpu}
%endif
mkdir -p %{buildroot}%{_datadir}/unifi/lib/native/Linux/%{unifi_arch}
mv Linux/%{unifi_arch}/libubnt_webrtc_jni.so %{buildroot}%{_libdir}/
ln -sr %{buildroot}%{_libdir}/libubnt_webrtc_jni.so \
%{buildroot}%{_datadir}/unifi/lib/native/Linux/%{unifi_arch}/
%endif
Regardless, the package is APPROVED and you can do the above after importing.
--
You are receiving this mail because:
You are on the CC list for the bug._______________________________________________
rpmfusion-developers mailing list -- [email protected]
To unsubscribe send an email to [email protected]
