https://bugzilla.rpmfusion.org/show_bug.cgi?id=5035
--- Comment #4 from Jaroslav Škarvada <[email protected]> ---
(In reply to Robert-André Mauchin from comment #3)
Thanks for the review, hopefully all fixed.
Spec: https://jskarvad.fedorapeople.org/gr-dab/gr-dab.spec
SRPM:
https://jskarvad.fedorapeople.org/gr-dab/gr-dab-0.2.1-2.20180925gita33609bd.fc29.src.rpm
> - BR: python-devel
>
> Specify python2-devel or python3-devel, python-devel is deprecated
>
Fixed
> - Add %{?_isa}
>
> Requires: %{name}%{?_isa} = %{version}-%{release}
>
Added to devel package
> - make %{?_smp_mflags} → %make_build
fixed
>
> - make install DESTDIR=%{buildroot} → %make_install
>
fixed
> - Globbing the major soname versionis now forbidden to avoid unintentional
> soname bump, please be more specific instead:
>
> %{_libdir}/*.so.*
>
added SONAME
> - Globbing %{python2_sitearch} is now forbidden too, please be more
> specific hire too:
>
> %{python2_sitearch}/*
>
fixed
> - You should own:
>
> [!]: Package requires other packages for directories it uses.
> Note: No known owner of /usr/lib64/cmake/grdab
>
fixed
> - Also Python 2 is deprecated, you should ask upstream to convert to Python
Whole gnuradio stack is python2 at the moment (gnuradio-3.7). AFAIK the 3.8
version should be python3 compatible. So we will switch in rawhide once it get
to stable.
> 3. (and python2-matplotlib is in need of a maintainer btw).
IMHO it's only needed for some simulation, IMHO it could be dropped in case of
trouble.
--
You are receiving this mail because:
You are on the CC list for the bug._______________________________________________
rpmfusion-developers mailing list -- [email protected]
To unsubscribe send an email to [email protected]
