https://bugzilla.rpmfusion.org/show_bug.cgi?id=5435

--- Comment #3 from Sérgio Basto <[email protected]> ---
(In reply to leigh scott from comment #2)
> Package approved, please fix the requires when you import.
> 
> 
> Add
> 
> Requires:       hicolor-icon-theme
> 
> for directory ownership for %{_datadir}/icons/hicolor/*/apps/smtube.png
> 
> I note you didn't port all the docs from the original spec
> 
> %doc smtube-%{smtube_ver}/Changelog smtube-%{smtube_ver}/Readme.txt
> %doc smtube-%{smtube_ver}/Release_notes.txt

 %{_docdir}/%{name}/ have the files 

> $ rpmlint
> '/home/leigh/Desktop/review-smtube/results/smtube-19.6.0-1.fc31.src.rpm' 
> 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
> 
> $ rpmlint
> '/home/leigh/Desktop/review-smtube/results/smtube-19.6.0-1.fc31.x86_64.rpm' 
> smtube.x86_64: E: incorrect-fsf-address /usr/share/doc/smtube/Readme.txt
> smtube.x86_64: W: no-manual-page-for-binary smtube
> 1 packages and 0 specfiles checked; 1 errors, 1 warnings.
> 
> 
> P.S fedora-review tool is broken again!

https://pagure.io/FedoraReview/issue/368

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
rpmfusion-developers mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to