Hi Mamoru, thanks for your help!
I created review request [1]. What is common way to download additional game data? Is there any best practice? I think it requires accepting EULA first, then extract pk3 files from original et linux installer. It crashed me on the test run, but maybe it just conflicts with previous plays of different version. 1. https://bugzilla.rpmfusion.org/show_bug.cgi?id=5824 On 10/31/20 1:18 AM, Mamoru TASAKA wrote: > Petr Menšík wrote on 2020/10/31 7:27: >> Hello developers, >> >> I am maintainer on Fedora and also work for Red Hat. >> >> I just created account on RPM Fusion. I would like to make package of >> etlegacy project[1]. It is Wolfenstein: Enemy Territory continuation, >> after the game code was open sourced. Required game data remains under >> EULA, which is reason I did not even try to make a review on Fedora. >> >> My current attempt[2] is stuck on missing debug information list. I >> think that means something strips built information. I have packaged >> several projects on Fedora. I admit I got tired fixing strange bugs >> during the build. Expected etlegacy packaging much easier. Maybe other >> eyes would find easily what I could not. >> >> It seems good enough game to have simple to install package. Recently >> packaged data downloader might help with user-friendly way to install >> data. >> >> Could anyone take a look at spec[2] and fix missing debug information? I >> would like to push into Review process later. >> >> 1. https://github.com/etlegacy/etlegacy >> 2. https://github.com/pemensik/etlegacy/blob/fedora/etlegacy.spec >> > > This line > https://github.com/pemensik/etlegacy/blob/6859ab35bd6b2cc6400537a7afebaf2fa9256772/etlegacy.spec#L59 > > > i.e. "exit 0" prevents from execution of %__debug_install_post and etc, > so creating > debuginfo and etc won't be done now. Remove this "exit 0". Oh, I thought it would not prevent it. Thanks! > > Note that after removing this line, rpmbuild now fails with > %__brp_mangle_shebangs , > because installed "/usr/lib/etlegacy/legacy/description.txt" file has > permission 0755 > ( i.e. this file is marked as executable ) but does not have any > shebang. Change the permission to > 0644. Oh thank you so much. I could not find what shebang reported, would not search this place. > > Regards, > Mamoru -- Petr Menšík PGP: DFCF908DB7C87E8E529925BC4931CA5B6C9FC5CB _______________________________________________ rpmfusion-developers mailing list -- [email protected] To unsubscribe send an email to [email protected]
