https://bugzilla.rpmfusion.org/show_bug.cgi?id=6383
Petr Menšík <pemen...@redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |pemen...@redhat.com
--- Comment #1 from Petr Menšík <pemen...@redhat.com> ---
I am not packager on rpmfusion.org yet, but I have made many reviews on Fedora.
I think this exclude on powerpc machine should have at least short
justification. Ideally it should have link in comment to an issue/bug filled
upstream to build also on %power64 platforms.
ExcludeArch: %{power64}
Also sources mention use of TinyXML2, which is already packaged in Fedora [1].
It might BuildRequires tinyxml2-devel. It also contains TinyEXIF code, which is
originally at different project [2]. If that code is compiled into resulting
binary, it must mention Provides: bundled(TinyEXIF) as a minimum. Better it
should unbundle and use separate package shared code. That would propably mean
review bug for Fedora.
I think for normal Fedora builds it should use just %cmake and %cmake_build
macros instead of %cmake3 and %cmake_build. But it should work until cmake 4 is
released. %cmake3 should be needed just for EPEL <=7 builds.
I would recommend using %autosetup instead of %setup, it makes patches applying
less annoying.
Otherwise I haven't found any blocker, I think the package is ready for
inclusion.
1. https://src.fedoraproject.org/rpms/tinyxml2
2. https://github.com/cdcseacave/TinyEXIF
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug._______________________________________________
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
