https://bugzilla.rpmfusion.org/show_bug.cgi?id=6508

--- Comment #9 from Kate Hsuan <h...@redhat.com> ---
Thank you for the reviewing this work.

(In reply to Hans de Goede from comment #7)
> Note there is still one issue with this after all the changes. The code
> searches for the configs from config/linux under the name of:
> 
> src/platformdata/PlatformData.h: line 92:
> 
> #define CAMERA_DEFAULT_CFG_PATH "/usr/share/defaults/etc/camera/"
> 
> And we install this as:
> 
> /usr/share/defaults/etc/ipu6
> 
> resp:
> 
> /usr/share/defaults/etc/ipu6ep

I had updated the udev script to resolve this before. 

> 
> So the 2 builds need to be patched to search under the right dir for the
> build, this worked during my testing since I had a leftover
> /usr/share/defaults/etc/camera/ from a previous manual install. Removing
> that causes things to stop working.
> 
> 
> I have come up with the following new %build using sed to patch this in
> dynamically:
> 
> %build
> for i in ipu6 ipu6ep; do
>   export PKG_CONFIG_PATH=%{_libdir}/$i/pkgconfig/
>   export LDFLAGS="$RPM_LD_FLAGS -Wl,-rpath=%{_libdir}/$i"
>   sed -i.orig
> "s|/usr/share/defaults/etc/camera/|/usr/share/defaults/etc/$i/|g" \
>     src/platformdata/PlatformData.h

To resolve this, symbolic links /run/camera and /usr/share/defaults/etc/camera
is created. The symbolic link /run/camera is managed by udev and it will
address to ipu6 or ipu6ep according to the udev rule.

I also will update this using your udev rule and adopt the same scenario with
libcamhal.so.

>   mkdir $i && pushd $i
>   %cmake -DCMAKE_BUILD_TYPE=Release -DIPU_VER=$i \
>          -DENABLE_VIRTUAL_IPU_PIPE=OFF -DUSE_PG_LITE_PIPE=ON \
>          -DUSE_STATIC_GRAPH=OFF ..
>   %make_build
>   popd
>   mv src/platformdata/PlatformData.h.orig src/platformdata/PlatformData.h
> done
> 
> Which fixes this. I'll attached an updated spec file with this.
Thank you :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

Reply via email to