Hi Barrie, Today Barrie wrote:
> Hi Tobi, > > I applied the patch and recompiled again to be sure. > > The strtoll work around did not apply with the patch for some reason, so I > manually added it to rrd_restore.c. > > This is the testing I have done on the new set of binaries. > > create - works > update - works > graph - works > dump - works, but has an incorrect year compared to the unix time in the xml. > e.g.year 2145 > > <!-- 2145-08-13 05:58:16 E. Australia Standard Time / 1246887000 --> oh ... > restore - does not reproduce the rrd file. It does create a rrd but with no > entries. Dump of restored rrd below. > > <?xml version="1.0" encoding="utf-8"?> > <!DOCTYPE rrd SYSTEM "http://oss.oetiker.ch/rrdtool/rrdtool.dtd"> > <!-- Round Robin Database Dump --><rrd> <version> 0003 </version> > <step> 300 </step> <!-- Seconds --> > <lastupdate> 1246974488 </lastupdate> <!-- 2009-07-07 23:48:08 E. > Australia Standard Time --> which is worse than before ... with your original patch is worked correctly ? cheers tobi > > <!-- Round Robin Archives --></rrd> > fetch - works > first - works > last - works > info - works > > I have attached my current rrd_restore.c and a zip of the files I created > during the test. > > FYI, my test is a ruby script calling a rrdtool wrapper I have written in > ruby. > > Cheers, Barrie > > > Tobias Oetiker wrote: > > Hi Barrie, > > > > just to be sure, here is the latest version of the patch ... > > > > --- rrd_restore.c (revision 1801) > > +++ rrd_restore.c (working copy) > > > > -- Tobi Oetiker, OETIKER+PARTNER AG, Aarweg 15 CH-4600 Olten, Switzerland http://it.oetiker.ch t...@oetiker.ch ++41 62 775 9902 / sb: -9900 _______________________________________________ rrd-developers mailing list rrd-developers@lists.oetiker.ch https://lists.oetiker.ch/cgi-bin/listinfo/rrd-developers