Hi Bernard, On Tue, Jul 13, 2010 at 03:53:33PM -0700, Bernard Li wrote: > On Tue, Jul 13, 2010 at 2:33 PM, Sebastian Harl <s...@tokkee.org> wrote: > > Sure, it's attached to this E-mail. > > Thanks, the patch works now.
Great :-) > I've found an issue though -- it looks like the permissions of the > default socket file is different from before: > > [1.4.3] > s--------- 1 root root 0 Jul 13 15:40 /tmp/rrdcached.sock > > [1.4 branch + patch] > srwxr-xr-x 1 root root 0 Jul 13 15:40 /tmp/rrdcached.sock Oh, in fact that's a bug in 1.4.3 which "accidentally" got fixed by my patch as well :-) Before, the listen_socket_t object representing the default socket was not initialized correctly which led to mode 0 (no permissions) being set for the socket file. > Otherwise, from my brief testing it seems to work as expected. Cool, thanks! > BTW, right now if you specify a socket via -l *and* have -m, -s or -P > after it, the daemon will merrily run. I think this should be > considered a syntax error since it's ambiguous. Well, I'd not consider that a syntax *error* but I think it warrants a warning being displayed on startup. Unless somebody beats me to it (*hint* ;-)), I'll provide a patch soonish. > Perhaps another way to deter this is to change the ordering of the > option displayed in the manpages/help. That might still be a good idea imho. > P.S. Not sure where the issue is but it seems that the replies you > sent back to the list have my email address as one of the recipient. > This is normally fine, however some how Gmail interpreted it as a > reply-to and thus when I reply back to your email it always tag on my > email address. Do you have any idea why? Hrm, my MUA sets the Mail-Followup-To header, which will include your E-mail address as well (besides the mailing-list address). Possibly, Gmail does not handle that correctly. However, I'd be somewhat surprised if that's actually the case but, other than that, I have no idea. Cheers, Sebastian -- Sebastian "tokkee" Harl +++ GnuPG-ID: 0x8501C7FC +++ http://tokkee.org/ Those who would give up Essential Liberty to purchase a little Temporary Safety, deserve neither Liberty nor Safety. -- Benjamin Franklin
signature.asc
Description: Digital signature
_______________________________________________ rrd-developers mailing list rrd-developers@lists.oetiker.ch https://lists.oetiker.ch/cgi-bin/listinfo/rrd-developers