On Dec 30, 2007 6:52 AM, Jean-François Trân <[EMAIL PROTECTED]> wrote:
> 2007/12/29, Andrew WC Brown <[EMAIL PROTECTED]>:
>
> > I just see these large blocks of:
> >
> > @shopping_list.should_receive(:milk)..and_return('milk')
> > @shopping_list.should_receive(:bagel).and_return('bagel')
> > @shopping_list.should_receive(:coffee).and_return('coffee')
> >
> > and it would be much clearer if I could list them in a hash instead.
>
> What about :
>
> {
> :milk => 'milk',
> :bagel => 'bagel',
> :coffee => 'coffee'
> }.each do |method, value|
> @shopping_list.should_receive(method).and_return(value)
> end
>
> So it doesn't need a #should_receive_the_following method.
You can certainly do that (and I have), but again, you'd lose the
benefit of a unique line number in the failure message.
This is something that is often lost under the banner of DRY. DRY
doesn't mean "type as few characters as you can." It means don't
repeat functionality or knowledge within a system. IMO, multiple calls
to the same methods, but with different data, are NOT duplication in
this sense.
_______________________________________________
rspec-users mailing list
rspec-users@rubyforge.org
http://rubyforge.org/mailman/listinfo/rspec-users
