>>>>> "Sviatoslav" == Sviatoslav Sviridov <[EMAIL PROTECTED]> writes:
Sviatoslav> Michael Richardson <[EMAIL PROTECTED]> wrote:
>> -----BEGIN PGP SIGNED MESSAGE-----
>>
>>
>> I added the following code to log_exit():
>>
>> void log_exit(int code, const char *file, int line)
>> {
>> static int error_count=0;
>>
>>
>> if(error_count++ > 10) {
>> abort();
>> }
>>
>>
>> To force it to bail earlier instead of overflowing the stack.
>>
>> As you can see at frame #50, it is trying to log that the connection went
>> away unexpectantly. I don't know why that might have happened, but clearly
>> the handling of this error is incorrect. Note that the client terminates
>> with non-zero error status (I don't know which one, but, I could find out),
>> which causes our cron job to fail, which is why we noticed this in the first
>> place.
Sviatoslav> I think, it's better to avoid recoursive calling of
Sviatoslav> exit_cleanup(), here is
Sviatoslav> main problem.
While, this is a good idea, I am not convinced it is the root cause of the
problem.
] ON HUMILITY: to err is human. To moo, bovine. | firewalls [
] Michael Richardson, Sandelman Software Works, Ottawa, ON |net architect[
] [EMAIL PROTECTED] http://www.sandelman.ottawa.on.ca/ |device driver[
] panic("Just another Debian GNU/Linux using, kernel hacking, security guy"); [
--
To unsubscribe or change options: http://lists.samba.org/mailman/listinfo/rsync
Before posting, read: http://www.tuxedo.org/~esr/faqs/smart-questions.html
