https://bugzilla.samba.org/show_bug.cgi?id=9894
Summary: Rsync can silently zero out chunks in a file Product: rsync Version: 3.0.9 Platform: All OS/Version: All Status: NEW Severity: critical Priority: P5 Component: core AssignedTo: way...@samba.org ReportedBy: a...@outlook.com QAContact: rsync...@samba.org map_ptr() handles read failures by zeroing out remaining chunk and returning the partially filled/all zero buffers to callers. It also fills error details in map_struct->status. It is caller's responsibility to check the status and handle this condition appropriately. It is probably OK to ignore this when we are generating checksums (as it might lead to a false mismatch, resulting in transfer of a non matching block) But in context of transfer (send_deflated_token()) when this error is ignored it leads to silent data corruption for receiver. Possible solutions are to log errors and disconnect such connection, or retry till timeout happens. No point in giving user a false impression that xfr is successful. Request dev to look at it with priority. Cheers, Ankur -- Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. -- Please use reply-all for most replies to avoid omitting the mailing list. To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html