https://bugzilla.samba.org/show_bug.cgi?id=10211

           Summary: Log lines sent to files should not human-readable-ize
                    numbers, ever
           Product: rsync
           Version: 3.1.0
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P5
         Component: core
        AssignedTo: [email protected]
        ReportedBy: [email protected]
         QAContact: [email protected]


Created attachment 9292
  --> https://bugzilla.samba.org/attachment.cgi?id=9292
Make end-of-sync log line not use commas if logfile_name!=NULL

There is no reason to do comma separation for numbers if the log lines are sent
to a file. Actually, parsing those log files becomes quite a bit messier if
they are.

Relatedly, the separator for the numbers seems to ignore locale, in Germany,
for example, a million plus 1/10 is written like this: 1.000.000,1 -- not that
I'd want either in my logfiles.

Attached is a patch. Not sure about the line width, but that is easily fixable.

-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
-- 
Please use reply-all for most replies to avoid omitting the mailing list.
To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync
Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html

Reply via email to