On Sat, May 23, 2020 at 4:37 AM Sebastian Andrzej Siewior < rs...@ml.breakpoint.cc> wrote:
> Wouldn't it be better to add support for a crypto library (like openssl) > which would provide optimized algorithms for more than just one platform > without the need to maintain it separately? > Adding optional support for openssl's crypto library is also a good idea. I've made rsync's MD5 code able to support using either the crypto library or the rsync-included MD5 code. I did not bother to try to support it for MD4 checksums, since those are mostly historical & there are some weird exceptions for really old rsync compatibility that would need to be worked out. However, I might make it where the main MD4 checksum is covered by openssl and just the historical ones get the historical code. I've also added a comment to the checksum.c file about my support of being able to distribute a dynamically linked version of rsync that links with the openssl and xxhash libraries (since they are both BSD 2-clause licensed), especially since this should (IMO) be considered to be covered under the System Libraries part of the GPL. ..wayne..
-- Please use reply-all for most replies to avoid omitting the mailing list. To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html