On Fri, Jun 09, 2000 at 05:01:58PM +0100, Adye, TJ (Tim) wrote:
> Hi Dave,
>
> > I'd prefer the shorter hack mostly because I don't want it to have to
> > malloc the extra strings just to get around the const
> > limitations.
>
> The current code does the malloc and copy (strdup) as well (and a good thing
> too, otherwise I'd have to make the copy outside unsafe_symlink(), and my
> change wouldn't be quite so simple). Since the pointers weren't const, it
> previously was able to point them at the copies. with my change it just uses
> a new local variable.
I obviously looked it over too quickly, and I'm not too good at reading
context diffs quickly. Sorry about that. In that case I don't have a
strong preference.
I guess I would still like to see what it looks like with just casts
instead of the extra local variables but maybe you're right that it's
cleaner the way you had it.
> > Once
> > you make that change and send it to me, I'll submit your change to
> > --copy-unsafe-links.
>
> OK, I'll make this change with the --delete statistics change, so I only
> have to check it all out once.
Actually I'll submit them separately but it's find to send them to me
together.
- Dave Dykstra
