On 02/25/2008 03:51 PM, Michael Biebl wrote:
> 2008/2/25, Michael Biebl <[EMAIL PROTECTED]>:
>> Hi
>>
>>  2008/2/25, Florian Riedl <[EMAIL PROTECTED]>:
>>
>>>  release. Most importantly, the GSSAPI input module has become an
>>  >  independent module. Formerly, the rsyslog core needed to be linked with
>>  >  GSSAPI libraries, which now no longer is required. Also, there now is an
>>
>>
>> Hm, rsyslogd_LDADD in Makefile.am still has  $(gss_libs).
>>  So when you enable the GSSAPI support, rsyslogd will be linked against
>>  the GSSAPI libraries. Has it been forgotten to remove $(gss_libs)
>>  while modularizing gssapi?
> 
> Some more comments:
> plugins/imtcp/Makefile.am
> builds imgssapi uncoditionally. Shouldn't imgssapi not be surrounded by
> if ENABLE_GSSAPI
> imgssapi_*
> ...
> endif
> 
> Also, rsyslogd_SOURCES still contains gss_misc.* and syslogd.c and
> net.c also have #ifdef USE_GSSAPI code. So it's not yet really
> possible to build the GSSAPI support in a separate module without
> linking the rsyslogd core against the GSSAPI libs.
> The changelog is thus a bit misleading.
> 
> Cheers,
> Michael

Hi Michael,

thanks for the comments, attached patch should resolve these problems.
http://pastebin.com/m638295ac

Regarding the #ifdefs in syslogd.c and net.c, they are used to 
conditionally compile some options, allowed senders list and such, no 
external GSSAPI code is needed so really only the module needs to be 
linked with the GSSAPI libs.
_______________________________________________
rsyslog mailing list
http://lists.adiscon.net/mailman/listinfo/rsyslog

Reply via email to