> -----Original Message----- > From: [EMAIL PROTECTED] [mailto:rsyslog- > [EMAIL PROTECTED] On Behalf Of Gerrard Geldenhuis > Sent: Tuesday, March 18, 2008 11:15 AM > To: rsyslog-users > Subject: Re: [rsyslog] Feedback requested "Last message logged n > times"... > > Hi > I personnally find it not very usefull to put it politely. I'd rather > have every message and every time stamp for the sake of acuracy and > precision then an attempt from the software to be intelligent. > > And if you get the benefit of a code clean up then double thumbs up > from > me.
It's actually a *big* cleanup, because in order to support that feature, we need to have A) some background tick processing to flush the "repeated message" every few (30 or 60) seconds (it prevents rsyslogd from being tickles - think powertop, green IT and all that) B) requires rsyslogd to keep multiple message objects alive for an extended period of time, because the message object is needed for comparison when a new message comes in. Among others, this prevents some advanced flow control options which would depend on message destruction *when the message is done* and not *when the next message arrives*. C) [estimate] almost half the code of the main action calling loop, and most of the complexity, is related to "last message repeated n times" D) it prevents future end-to-end ACK capabilities (e.g. message is only acked after being written to DB) E) requires additional synchronization slowing down parallel processing (granted, just a little bit, but...) F) requires a "duplicate message capability" (some more code) G) ... and probably a few more spots ... I should have added this information to the initial message, too. These are *my* primary drivers for the idea to get rid of it ;) Rainer _______________________________________________ rsyslog mailing list http://lists.adiscon.net/mailman/listinfo/rsyslog
