> -----Original Message----- > From: [email protected] [mailto:[email protected]] > Sent: Tuesday, January 25, 2011 8:28 PM > To: Rainer Gerhards > Cc: rsyslog-users > Subject: Re: [rsyslog] imfile paragraph patch > > On Tue, 25 Jan 2011, Rainer Gerhards wrote: > > > On 01/17/2011 07:22 PM, [email protected] wrote: > >> Attached is a test file to test various modes of imfile, the results > of > >> the test, and a consolodated patch going back to > >> f7c20920046ebcb94eadadf1ebad97b634a12a2d (your merge of the other > imfile > >> fixes) > > > > I have merged this as well now. Please re-check, but I think it is > OK. I will > > merge this into v5-devel tomorrow if I don't hear anything against > that :) > > I will test this today. did you include the test file and make a unit > test > for this?
I have to admit I did not get that you wanted me to do that ;) Will see that I add a testcase later today. > > >> One thing that surprised me is that it doesn't appear that control > >> characters in imfile are escaped the way that network received logs > are > >> escaped. Did I miss some way to enable this? Initially I thought > that > >> possibly only \n wasn't escaped, but some of my mistakes generated > other > >> control characters. > > > > I guess this issue simply never came up. The way imfile works, it > needs to do > > the sanitazion itself. Because that would happen in the parsing step, > but > > imfile data can not be run through the parser. > > Ok, I'll do some digging and find the routine that's called to do the > sanitizing and see if we can just add a call to the existing code. I probably makes sense to expose this function as a callable API (especially as it needs some update to be more Unicode-friendly). Will put this on the list as well. Side-Note: I will also see that I merge some fixes from older releases in today. This can be a bit more time-consuming due to interface changes. Rainer _______________________________________________ rsyslog mailing list http://lists.adiscon.net/mailman/listinfo/rsyslog http://www.rsyslog.com
