Patch looks good to us - Thank you! Brian
On Tue, Oct 30, 2012 at 11:14 AM, Brian Knox <bri...@talksum.com> wrote: > Eyeballing it it looks good to me as well. Let me run it by Dave real > quick and I'll get back to the list! > > Brian > > On Tue, Oct 30, 2012 at 10:27 AM, Rainer Gerhards > <rgerha...@hq.adiscon.com> wrote: >> Brian, >> >> any thought's. From brief look (and without zmq knowledge), this looks >> pretty good to me ;) >> >> Rainer >> >>> -----Original Message----- >>> From: rsyslog-boun...@lists.adiscon.com [mailto:rsyslog- >>> boun...@lists.adiscon.com] On Behalf Of Martin Nilsson >>> Sent: Tuesday, October 30, 2012 3:22 PM >>> To: rsyslog@lists.adiscon.com >>> Subject: [rsyslog] Patch for imzmq3 >>> >>> Hi, >>> >>> I've been trying to setup imzmq3 with a PULL socket type, however >>> rsyslog >>> would segault when I tried it. This patch solved the issue for me: >>> >>> diff -ru rsyslog-7.2.0.orig/plugins/imzmq3/imzmq3.c >>> rsyslog-7.2.0/plugins/imzmq3/imzmq3.c >>> --- rsyslog-7.2.0.orig/plugins/imzmq3/imzmq3.c 2012-10-26 >>> 15:57:03.193901201 +0200 >>> +++ rsyslog-7.2.0/plugins/imzmq3/imzmq3.c 2012-10-26 >>> 15:57:24.961651259 +0200 >>> @@ -375,10 +375,10 @@ >>> zsocket_set_rcvhwm(*sock, info->rcvHWM); >>> >>> /* Set subscriptions.*/ >>> - for (ii = 0; ii < sizeof(info->subscriptions)/sizeof(char*); ++ii) >>> - zsocket_set_subscribe(*sock, info->subscriptions[ii]); >>> - >>> - >>> + if (info->type == ZMQ_SUB) { >>> + for (ii = 0; ii < sizeof(info->subscriptions)/sizeof(char*); >>> ++ii) >>> + zsocket_set_subscribe(*sock, info->subscriptions[ii]); >>> + } >>> >>> /* Do the bind/connect... */ >>> if (info->action==ACTION_CONNECT) { >>> >>> After applying this, imzmq3 works fine with PULL and I am happy. >>> >>> Regards, >>> /Martin >>> _______________________________________________ >>> rsyslog mailing list >>> http://lists.adiscon.net/mailman/listinfo/rsyslog >>> http://www.rsyslog.com/professional-services/ >>> What's up with rsyslog? Follow https://twitter.com/rgerhards >>> NOTE WELL: This is a PUBLIC mailing list, posts are ARCHIVED by a >>> myriad of sites beyond our control. PLEASE UNSUBSCRIBE and DO NOT POST >>> if you DON'T LIKE THAT. >> _______________________________________________ >> rsyslog mailing list >> http://lists.adiscon.net/mailman/listinfo/rsyslog >> http://www.rsyslog.com/professional-services/ >> What's up with rsyslog? Follow https://twitter.com/rgerhards >> NOTE WELL: This is a PUBLIC mailing list, posts are ARCHIVED by a myriad of >> sites beyond our control. PLEASE UNSUBSCRIBE and DO NOT POST if you DON'T >> LIKE THAT. _______________________________________________ rsyslog mailing list http://lists.adiscon.net/mailman/listinfo/rsyslog http://www.rsyslog.com/professional-services/ What's up with rsyslog? Follow https://twitter.com/rgerhards NOTE WELL: This is a PUBLIC mailing list, posts are ARCHIVED by a myriad of sites beyond our control. PLEASE UNSUBSCRIBE and DO NOT POST if you DON'T LIKE THAT.
