On Fri, 15 Jan 2016, David Lang wrote:
On Fri, 15 Jan 2016, Rainer Gerhards wrote:
Hi folks,
I would like to get some feedback on this potentially
compatibility-breaking but long-standing bug:
https://github.com/rsyslog/rsyslog/pull/604
My feeling is that fixing the off-by-one error is good, but eliminating the
fields that you use to populate a standard property should not be done by
default, especially if it hasn't been done up to now.
Adding an option to do so is reasonable, but someone may want to check if the
property was populated from JSON or from some other fallback (plus it would
break existing configs)
as an opt-in option, it is a good idea. As a change in behavior it's
horrible.
If we didn't have any existing behavior, there would be room for a lot more
discussion. I'm not sure which way that discussion would end up (I see valid
reasons on both sides) but breaking existing configs would be a major issue,
and this is nowhere near a big enough reason.
put a tickler somewhere so that we can have this discussion when we look at
moving to 9.x, that would be a time to consider changeing the defaults. We have
a few other things that fall in this category as well, but nothing big.
David Lang
_______________________________________________
rsyslog mailing list
http://lists.adiscon.net/mailman/listinfo/rsyslog
http://www.rsyslog.com/professional-services/
What's up with rsyslog? Follow https://twitter.com/rgerhards
NOTE WELL: This is a PUBLIC mailing list, posts are ARCHIVED by a myriad of
sites beyond our control. PLEASE UNSUBSCRIBE and DO NOT POST if you DON'T LIKE
THAT.
