2016-03-22 15:57 GMT+01:00 David Lang <[email protected]>: > On Tue, 22 Mar 2016, Rainer Gerhards wrote: > >> 2016-03-21 22:27 GMT+01:00 David Lang <[email protected]>: >>> >>> The json produced by dynastats needs some work, currently it looks like: >>> >>> >>> {"name":"msg_per_host","origin":"dynstats.bucket","z-scribe1r-b":80,"SWEB10":67} >>> >>> This is not something that can readily be handled, and since the hostname >>> is >>> at the same level as name or origin, it's just begging for abuse. >>> >>> It would be far better to put these into an array that could then be >>> handled >>> via foreach >>> >>> something like: >>> >>> {"name":"msg_per_host","origin":"dynstats.bucket",items:["z-scribe1r-b":80,"SWEB10":67]} >>> >>> Yes, this has hit a stable release, but the docs still haven't made it to >>> the website (which is still showing 8.16) and so I don't think anyone is >>> depending on this syntax yet, so I think we can get away with changing >>> it. >> >> >> Two things: first of all, the doc tarball went out and probably is >> included in some distros. Also, this *is* the released version. So I >> think it would be a bad thing to change this without mentioning it. If > > > I agree it should be mentioned, probably in the release announcement > >> there is agreement to change, I agree it's not a big deal at this >> stage. While seldom, we have made some breaking changes of such a >> small magnitude in the past as well. > > > So do people agree or disagree with my suggested change?
I am neutral, as I don't see any use case for me and my customers for this functionality. I also don't think it breaks any rsyslog concept (that's why I merged in the frist place). Conceptionally, I am leaning towards your argument, but I don't want to put any effort into a patch or strong discussion TBH. Rainer > >> Secondly, the website update failed due to a merge conflict inside a >> script that wasn't properly detected. This is fixed now. So the >> correct version will hopefully show up soon on the site (but IMHO >> without affecting anything else, as said in the first paragraph). > > > Glad to hear this. > > > David Lang > _______________________________________________ > rsyslog mailing list > http://lists.adiscon.net/mailman/listinfo/rsyslog > http://www.rsyslog.com/professional-services/ > What's up with rsyslog? Follow https://twitter.com/rgerhards > NOTE WELL: This is a PUBLIC mailing list, posts are ARCHIVED by a myriad of > sites beyond our control. PLEASE UNSUBSCRIBE and DO NOT POST if you DON'T > LIKE THAT. _______________________________________________ rsyslog mailing list http://lists.adiscon.net/mailman/listinfo/rsyslog http://www.rsyslog.com/professional-services/ What's up with rsyslog? Follow https://twitter.com/rgerhards NOTE WELL: This is a PUBLIC mailing list, posts are ARCHIVED by a myriad of sites beyond our control. PLEASE UNSUBSCRIBE and DO NOT POST if you DON'T LIKE THAT.
